test: increase timeout in break-on-uncaught #10822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
reviewed
Jan 15, 2017
| setTimeout( | ||
| assertHasPaused.bind(null, client), | ||
| common.platformTimeout(3000) | ||
| ); |
There was a problem hiding this comment.
/cc @nodejs/testing
Might it be better to use a short setInterval() (or a setTimeout() that renews itself if the thing hasn't paused yet) and let the test time out via test.py rather than having an AssertionError here?
There was a problem hiding this comment.
(That will also have the benefit of not requiring a minimum of 6 seconds for the test to run.)
There was a problem hiding this comment.
Maybe like this?:
...
let interval;
function runTest(client) {
client.req(
{
command: 'setexceptionbreak',
arguments: {
type: 'uncaught',
enabled: true
}
},
function(error) {
assert.ifError(error);
client.on('exception', function(event) {
exceptions.push(event.body);
});
client.reqContinue(function(error) {
assert.ifError(error);
interval = setInterval(assertHasPaused.bind(null, client), 1);
});
}
);
}
function assertHasPaused(client) {
if (exceptions.length > 0) {
assert.strictEqual(exceptions.length, 1,
'debugger did not pause on exception');
assert.strictEqual(exceptions[0].uncaught, true);
assert.strictEqual(exceptions[0].script.name, testScript);
assert.strictEqual(exceptions[0].sourceLine + 1, throwsOnLine);
asserted = true;
client.reqContinue(assert.ifError);
clearInterval(interval);
}
}
}There was a problem hiding this comment.
It makes sense. Tested locally as well. Thanks :-)
thefourtheye
force-pushed
the
debugger-break-on-uncaught
branch
from
33d556f
to
a3c8ffd
Compare
|
@Trott Does this LGTY? |
Trott
reviewed
Jan 28, 2017
| }); | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| function assertHasPaused(client) { | ||
| if (!exceptions.length) return; | ||
|
|
||
| assert(exceptions.length, 'no exceptions thrown, race condition in test?'); |
There was a problem hiding this comment.
If I'm not mistaken, it's impossible for this assertion to fire given the check two lines above. So this line can probably be removed?
Trott
approved these changes
Jan 28, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received.
thefourtheye
force-pushed
the
debugger-break-on-uncaught
branch
from
a3c8ffd
to
bac94e6
Compare
|
@Trott I updated the PR with your suggestion. I'll land this today, if you have no objections. |
santigimeno
approved these changes
Jan 28, 2017
|
Landed in cc899a4 |
thefourtheye
added a commit
that referenced
this pull request
Jan 30, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: #10822 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
2 tasks
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: #10822 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: nodejs#10822 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: #10822 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: #10822 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the failures suggest, this test expects the uncaught exception to
be thrown within 100 milliseconds, but on some of the test machines it
takes longer than that limit to notify the exception. Thats why the
test was failing.
This patch increases the timeout to three seconds, with platform
specific timeout value.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Refer: #10456